20250220-misc-UnalignedWord64 #8482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… read/write unaligned" -- provokes sanitizer on amd64, and is not portable (e.g. different behavior on Intel vs AMD). all performance-sensitive word64 reads/writes should be on known-aligned data.
…fined(__cplusplus) (fixes wolfSSL#8478).
…es some false positive -Wreturn-stack-addresses from clang++).
SparkiDev
approved these changes
Feb 20, 2025
dgarske
approved these changes
Feb 20, 2025
|
retest this please ( |
JacobBarthelmeh
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
misc.c: undo changes in 82b50f1 "when Intel x64 build, assume able to read/write unaligned" -- provokes sanitizer on amd64, and is not portable (e.g. different behavior on Intel vs AMD). all performance-sensitiveword64reads/writes should be on known-aligned data.wolfssl/wolfcrypt/types.h: don't defineHAVE_EMPTY_AGGREGATESwhendefined(__cplusplus)(fixes #8478).wolfcrypt/test/test.c: fix return values incamellia_test()(also fixes some false positive-Wreturn-stack-addresses fromclang++).tested with
wolfssl-multi-test.sh ... quantum-safe-wolfssl-all-noasm-sanitizer 'quantum-safe-wolfssl-all-clang\+\+-latest'(the latter a new scenario).