Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PQC Clang-tidy fixes #8493

Merged

Conversation

Frauschi
Copy link
Contributor

Fixes two Clang-tidy warnings caused by #7821 (sent via mail by @dgarske).

Fixes two clang-tidy warnings in error cases.

Signed-off-by: Tobias Frauenschläger <[email protected]>
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Feb 24, 2025

Okay to test. Contributor agreement on file. Thank you @Frauschi

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes the clang-tidy

@dgarske
Copy link
Contributor

dgarske commented Feb 24, 2025

Retest this please: Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passes pq-all-clang-tidy pq-hybrid-all-rpk-clang-tidy quantum-safe-wolfssl-all-clang-tidy quantum-safe-wolfssl-all-smallstack-clang-tidy quantum-safe-wolfssl-all-intelasm-sp-asm-sanitizer quantum-safe-wolfssl-all-intelasm-sp-asm-valgrind

@douzzer douzzer merged commit a856415 into wolfSSL:master Feb 24, 2025
177 of 178 checks passed
@Frauschi Frauschi deleted the pqc_clang_tidy branch February 24, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants