Digest testing: improve #8501
Merged
Digest testing: improve #8501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
digest_test_rework
branch
from
69221ca to
ad0c9b8
Compare
SparkiDev
force-pushed
the
digest_test_rework
branch
11 times, most recently
from
9c29c5f to
b1ad757
Compare
Make testing digests consistent. Add KATs for all digests. Check unaligned input and output works. Perform chunking tests for all digests. Fix Blake2b and Blake2s to checkout parameters in update and final functions. Fix Shake256 and Shake128 to checkout parameters in absorb and squeeze blocks functions. Add default digest size enums for Blake2b and Blake2s.
SparkiDev
force-pushed
the
digest_test_rework
branch
from
b1ad757 to
6016cc0
Compare
dgarske
approved these changes
Feb 25, 2025
dgarske
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make testing digests consistent.
Add KATs for all digests.
Check unaligned input and output works.
Perform chunking tests for all digests.
Fix Blake2b and Blake2s to checkout parameters in update and final functions.
Fix Shake256 and Shake128 to checkout parameters in absorb and squeeze blocks functions.
Add default digest size enums for Blake2b and Blake2s.
Testing
Checklist