Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCS Pad: public API to do PKCS padding #8502

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

SparkiDev
Copy link
Contributor

@SparkiDev SparkiDev commented Feb 25, 2025

Description

PKCS padding adds length of padding as repeated padding byte.
Use the new function in all places.

Fixes zd#19391

Testing

./configure --enable-pkcs7
make test

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Feb 25, 2025
@SparkiDev
Copy link
Contributor Author

retest this please

@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Feb 25, 2025
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this cleanup

@dgarske dgarske self-assigned this Feb 25, 2025
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple cast issues.

@dgarske
Copy link
Contributor

dgarske commented Feb 25, 2025

Retest this please: "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:"

@SparkiDev SparkiDev assigned dgarske and unassigned SparkiDev Feb 26, 2025
@SparkiDev SparkiDev removed the request for review from wolfSSL-Bot February 26, 2025 01:49
PKCS padding adds length of padding as repeated padding byte.
Use the new function in all places.
@dgarske
Copy link
Contributor

dgarske commented Feb 26, 2025

Retest this please: Found unhandled hudson.remoting.RequestAbortedException exception: java.io.StreamCorruptedException: invalid stream header: 636F7272

@dgarske dgarske merged commit 92ed003 into wolfSSL:master Feb 26, 2025
178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants