[GB-Mobile Integration] Fix for Backspace does not outdent nested list item #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essed, regarless of the position of the caret in the field. Previously it was only called when the caret was at beginning of the field.
…backspace in case selection is active in the editor
daniloercoli
added
enhancement
Gutenberg
|
👋 @daniloercoli ! I'm assuming we should still work to merge this PR since the related issue is still open. Do you agree @mkevins, @daniloercoli ? |
Hi @mchowning 👋 😄 I somehow missed the original ping and just saw this one, so my apologies for the long delay. I agree, this is worth pursuing. I'm not sure off-hand whether the proposed solution needs to be updated to be current with all the changes from then to now. Do you have an idea of the priority of the original issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step required to fix wordpress-mobile/gutenberg-mobile#1027
@mkevins has reported the problem with backspace and nested lists, and already proposed a solution here. In this PR I started from scratch, but ended up with similar code.
Please, test this PR by pointing the experimental branch here https://github.com/wordpress-mobile/gutenberg-mobile/tree/experimental/fix-backspace-outdent-on-nested-lists to the full hash
fbf98c1af64552a01f1ae203d295b79b8362c629of this branch.Review
@mkevins
Note: I run both kotlin unit tests, and Java connected tests on this PR without finding any issue.