Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stock photo caption and include it when uploading a photo #13829

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ data class MediaItem(
data class StockMediaIdentifier(
val url: String?,
val name: String?,
val title: String?
val title: String?,
val caption: String?
) : Identifier(STOCK_MEDIA_IDENTIFIER)

data class GifMediaIdentifier(
Expand All @@ -62,6 +63,7 @@ data class MediaItem(
parcel.writeString(this.url)
parcel.writeString(this.name)
parcel.writeString(this.title)
parcel.writeString(this.caption)
}
is GifMediaIdentifier -> {
parcel.writeParcelable(this.largeImageUri.uri, flags)
Expand Down Expand Up @@ -93,7 +95,12 @@ data class MediaItem(
LocalId(parcel.readInt())
}
STOCK_MEDIA_IDENTIFIER -> {
StockMediaIdentifier(parcel.readString(), parcel.readString(), parcel.readString())
StockMediaIdentifier(
parcel.readString(),
parcel.readString(),
parcel.readString(),
parcel.readString()
)
}
GIF_MEDIA_IDENTIFIER -> {
GifMediaIdentifier(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class StockMediaInsertUseCase(
emit(InsertModel.Progress(actionTitle))
val result = stockMediaStore.performUploadStockMedia(site, identifiers.mapNotNull { identifier ->
(identifier as? StockMediaIdentifier)?.let {
StockMediaUploadItem(it.name, it.title, it.url)
StockMediaUploadItem(it.name, it.title, it.url, it.caption)
}
})
emit(when {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class StockMediaDataSource
.mapNotNull {
it.url?.let { url ->
MediaItem(
StockMediaIdentifier(it.url, it.name, it.title),
StockMediaIdentifier(it.url, it.name, it.title, it.caption),
url,
it.name,
IMAGE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@ class StockMediaInsertUseCaseTest : BaseUnitTest() {
private val title = "title"
private val name = "name"
private val thumbnail = "image.jpg"
private val caption = "caption"
private val stockMediaItem = StockMediaItem(
"id",
name,
title,
url,
"123",
thumbnail
thumbnail,
caption
)

@Before
Expand All @@ -46,7 +48,7 @@ class StockMediaInsertUseCaseTest : BaseUnitTest() {

@Test
fun `uploads media on insert`() = test {
val itemToInsert = Identifier.StockMediaIdentifier(url, name, title)
val itemToInsert = Identifier.StockMediaIdentifier(url, name, title, caption)
val insertedMediaModel = MediaModel()
val mediaId: Long = 10
insertedMediaModel.mediaId = mediaId
Expand All @@ -60,6 +62,6 @@ class StockMediaInsertUseCaseTest : BaseUnitTest() {
(result[1] as InsertModel.Success).apply {
assertThat(this.identifiers).containsExactly(RemoteId(mediaId))
}
verify(stockMediaStore).performUploadStockMedia(site, listOf(StockMediaUploadItem(name, title, url)))
verify(stockMediaStore).performUploadStockMedia(site, listOf(StockMediaUploadItem(name, title, url, caption)))
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ class StockMediaDataSourceTest : BaseUnitTest() {
private val title = "title"
private val name = "name"
private val thumbnail = "image.jpg"
private val caption = "caption"
private val stockMediaItem = StockMediaItem(
"id",
name,
title,
url,
"123",
thumbnail
thumbnail,
caption
)

@Before
Expand Down Expand Up @@ -87,7 +89,7 @@ class StockMediaDataSourceTest : BaseUnitTest() {
assertThat(this.data).hasSize(1)
assertThat(this.data).containsExactly(
MediaItem(
StockMediaIdentifier(url, name, title),
StockMediaIdentifier(url, name, title, caption),
url,
name,
IMAGE,
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ ext {
androidxWorkVersion = "2.4.0"

daggerVersion = '2.29.1'
fluxCVersion = '1.9.0'
fluxCVersion = '5d6f6ce247a0ca6a99fc2d069f6461a20d3c668d'

appCompatVersion = '1.0.2'
coreVersion = '1.2.0'
Expand Down
2 changes: 1 addition & 1 deletion libs/gutenberg-mobile
Submodule gutenberg-mobile updated 56 files
+4 −0 RELEASE-NOTES.txt
+1,941 −1,870 bundle/ios/App.js
+1 −1 bundle/ios/App.js.map
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ar.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/bg.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/bo.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ca.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/cs.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/cy.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/da.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/de.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/el.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-au.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-ca.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-gb.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-nz.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/en-za.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/es-ar.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/es-cl.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/es-cr.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/es.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/fa.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/fr.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/gl.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/he.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/hr.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/hu.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/id.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/is.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/it.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ja.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ka.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ko.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/nb.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/nl-be.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/nl.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/pl.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/pt-br.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/pt.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ro.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ru.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sk.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sq.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sr.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/sv.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/th.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/tr.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/uk.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/ur.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/vi.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/zh-cn.json
+1 −1 bundle/ios/assets/gutenberg/packages/react-native-editor/i18n-cache/data/zh-tw.json
+1 −1 gutenberg
+1 −1 package-lock.json
+1 −1 package.json
+21 −0 src/strings-overrides.js