feat: Authenticate private resource requests #21331
Open
+127
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unauthenticated requests failed when attempting to load resources from a private site, e.g., an image.
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration listtree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33
+| \--- org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596
-\--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 (*)
+\--- org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596 (*) |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21331-172e55e | |
| Commit | 172e55e | |
| Direct Download | wordpress-prototype-build-pr21331-172e55e.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21331-172e55e | |
| Commit | 172e55e | |
| Direct Download | jetpack-prototype-build-pr21331-172e55e.apk |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java
Fixed
Show fixed
Hide fixed
The proxy is required to authenticate the request with a bearer token.
This was added to mirror the `shouldInterceptRequest` method signature, but is unnecessary complexity.
Mirror the iOS method structure.
dcalhoun
commented
Oct 30, 2024
|
|
||
| String proxyUrl = url.toString(); | ||
| if (mIsPrivateAtomic) { | ||
| proxyUrl = getPrivateResourceProxyUrl(url); |
There was a problem hiding this comment.
Private Atomic sites require a proxy for request authentication (D38925-code).
jkmassel
reviewed
Oct 30, 2024
libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java
Outdated
Show resolved
Hide resolved
Likely better performance and accuracy.
libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java
Fixed
Show fixed
Hide fixed
Address lint error regarding a common source of bugs. #21331 (review)
… into feat/authenticate-private-resource-requests
|
|
👋🏻 @jkmassel. I updated this with the merged wordpress-mobile/GutenbergKit#30 and the latest from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Description
Authenticate resource requests originating from within the WebView so that
requests to private sites succeed.
To Test:
See wordpress-mobile/GutenbergKit#34.
Regression Notes
Gutenberg Mobile or Aztec editors fail.
Manually tested both editors.
None, feels unnecessary for this currently experimental editor feature.
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):