Skip to content

Commit

Permalink
Distinguish between DashboardGoogleDomainsCard- Cell and View i18n
Browse files Browse the repository at this point in the history
This issue was revealed by a strings generation _warning_:

[12:54:11]: ▸ Key "mySite.domain.focus.card.title" used with multiple values. Value "News" kept. Value "Reclaim your Google Domains" ignored.

Unfortunately, we don't have the tooling at the moment to translate this
warning into an error.
See wordpress-mobile/release-toolkit#446
  • Loading branch information
mokagio committed Aug 21, 2023
1 parent 410e597 commit 418252c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ extension DashboardGoogleDomainsCardCell: DashboardGoogleDomainsCardCellProtocol
private extension DashboardGoogleDomainsCardCell {
enum Strings {
static let cardTitle = NSLocalizedString(
"mySite.domain.focus.card.title",
"mySite.domain.focus.cardCell.title",
value: "News",
comment: "Title for the domain focus card on My Site"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@ private extension DashboardGoogleDomainsCardView {
enum Strings {

static let contentTitle = NSLocalizedString(
"mySite.domain.focus.card.title",
"mySite.domain.focus.cardView.title",
value: "Reclaim your Google Domains",
comment: "Title of the domain focus card on My Site"
)

static let contentDescription = NSLocalizedString(
"mySite.domain.focus.card.description",
"mySite.domain.focus.cardView.description",
value: "As you may know, Google Domains has been sold to Squarespace. Transfer your domains to WordPress.com now, and we'll pay all transfer fees plus an extra year of your domain registration.",
comment: "Description of the domain focus card on My Site"
)

static let buttonTitle = NSLocalizedString(
"mySite.domain.focus.card.button.title",
"mySite.domain.focus.cardView.button.title",
value: "Transfer your domains",
comment: "Button title of the domain focus card on My Site"
)
Expand Down

0 comments on commit 418252c

Please sign in to comment.