Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with search results disappearing after returning from site details #24121

Merged
merged 5 commits into from
Feb 28, 2025
Merged

Fix an issue with search results disappearing after returning from site details #24121

merged 5 commits into from
Feb 28, 2025
+10 −3

Conversation

kean
Copy link
Contributor

@kean kean commented Feb 26, 2025

Fixes #24112.

Before:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-26.at.13.17.01.mp4

After:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-26.at.13.18.49.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from crazytonyli February 26, 2025 18:20
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 26, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 25.8. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 26, 2025 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24121-45c1b7c
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit45c1b7c
App Center BuildWPiOS - One-Offs #11563
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 26, 2025 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24121-45c1b7c
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit45c1b7c
App Center Buildjetpack-installable-builds #10593
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge February 26, 2025 19:00
@kean kean mentioned this pull request Feb 26, 2025
Closed
@kean kean added this to the 25.8 milestone Feb 27, 2025
@kean kean added the Reader label Feb 27, 2025
crazytonyli
crazytonyli reviewed Feb 27, 2025
View reviewed changes
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderSearchViewController.swift Outdated
@@ -41,6 +41,7 @@ final class ReaderSearchViewController: UIViewController {
private var currentChildVC: UIViewController?
private var previousSearchTopic: ReaderAbstractTopic?
private let contextManager = ContextManager.shared
private var isFirstAppearance = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this value supposed to be true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. No idea how I tested it

WordPress/Classes/ViewRelated/Reader/Controllers/ReaderSearchViewController.swift
@@ -62,8 +63,11 @@ final class ReaderSearchViewController: UIViewController {
override func viewDidAppear(_ animated: Bool) {
super.viewDidAppear(animated)

DispatchQueue.main.async {
self.searchController.searchBar.becomeFirstResponder()
if isFirstAppearance {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is isMovingToParent applicable here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I trust viewDidAppear(_ animated: Bool) and isFirstAppearance more.

@kean kean force-pushed the fix/search-closing branch from a9974db to 17e3677 Compare February 27, 2025 23:28
@kean kean requested a review from crazytonyli February 27, 2025 23:28
@kean kean added this pull request to the merge queue Feb 28, 2025
Merged via the queue into trunk with commit 21f4c95 Feb 28, 2025
25 checks passed
@kean kean deleted the fix/search-closing branch February 28, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes

Assignees
No one assigned
Labels
Reader
Projects
None yet
Milestone
25.8
Development

Successfully merging this pull request may close these issues.

Reader: Search cancels after returning from one of the result details
4 participants
@kean @dangermattic @wpmobilebot @crazytonyli