Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPM Prep – Move some async perform types at the WordPressComRESTAPIInterface level #788

Open
wants to merge 17 commits into
base: trunk
Choose a base branch
from
Open

SPM Prep – Move some async perform types at the WordPressComRESTAPIInterface level #788

wants to merge 17 commits into from

Commits on Apr 12, 2024

  1. Remove an enum builder in favor of default associated value

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6f0f3c4 View commit details
    Browse the repository at this point in the history

  2. Update access control to components called by removed types

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    465d589 View commit details
    Browse the repository at this point in the history

  3. Move upload(... definition before perform(... 

    This is just a convenience refactor to make future diff clearer
    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    eb13fb9 View commit details
    Browse the repository at this point in the history

  4. Make a couple of properties used in async API public

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b56f5d3 View commit details
    Browse the repository at this point in the history

  5. Remove a stray double new line

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6f046e1 View commit details
    Browse the repository at this point in the history

  6. Move processError to an extension on WordPressComRESTAPIInterfacing

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5484521 View commit details
    Browse the repository at this point in the history

  7. Require URLSession in root async perform method

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    64e7698 View commit details
    Browse the repository at this point in the history

  8. Move session argument before taskCreated 

    As per Swift API naming guidelines on arguments with default values
    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5f2c8fd View commit details
    Browse the repository at this point in the history

  9. Require invalidTokenHandler in perform

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    38c2e25 View commit details
    Browse the repository at this point in the history

  10. Move root perform definition to WordPressComRESTAPIInterfacing

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e4f566b View commit details
    Browse the repository at this point in the history

  11. Extract logic to create builder with locale to extension

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    23bc2ab View commit details
    Browse the repository at this point in the history

  12. Add new localeValue property to WordPressComRESTAPIInterfacing

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8d0d3df View commit details
    Browse the repository at this point in the history

  13. Move request builder to WordPressComRESTAPIInterfacing extension

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    bc6dcd1 View commit details
    Browse the repository at this point in the history

  14. Redefine APIResult typealias in the context of `WPComRESTAPIInterfa… 

    …cing`
    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f47621a View commit details
    Browse the repository at this point in the history

  15. Move urlSession and invalidTokenHandler to API interface protocol

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    70cbfd0 View commit details
    Browse the repository at this point in the history

  16. Move a couple more perform types to API protocol

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7d8877b View commit details
    Browse the repository at this point in the history

  17. Remove a stray double new line

    @mokagio
    mokagio committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    19357f4 View commit details
    Browse the repository at this point in the history