Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlite database adapter #175

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ategt
Copy link

@ategt ategt commented Oct 10, 2018

I really like this project and found reading the code to be simple and pleasant. Currently, I am using dejavu on multiple computers, which can not always communicate, and so while PostgreSQL is my database of choice, using SQLite seems like the right solution for me at the moment.

I am not sure what the goals of this project are and I know that SQLite is going to run slower than MySQL and be a challenge to use at scale, but it works for me, and I thought that perhaps it may be useful for someone else, too.

I further realize that my current solution, add an import to use this implementation, may not be the best way to handle the scenario, but I also do not want to force other users, who do not want SQLite, into installing sqlite3 dependencies and my attempts to devise a more elegant solution to that problem seemed to complicate the code unnecessarily. There is certainly a solution that works for everyone, and what I have done is more of a compromise than an answer, but I feel that it is a reasonable compromise, and I welcome any input on how to improve that aspect of this request.

All of that said, dejavu has been quite helpful to me in several ways and I wanted to give back. Thank you for the consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant