Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error that is not matched an argument type #232

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SeunghoonBaek
Copy link

Changed

  • Pass correct argument variable.

Comment

Hello dejavu members,

I'm interesting in your audio fingerprint work.
I'm in diving your code for understanding what it works well. :)
I've found that the latest dejavu has a small runtime error while I tried to get an audio fingerprint.

Please check this PR and let me know your opinion!
Thanks :)

Copy link

@raedatoui raedatoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i just opened a PR with the same change. ill approve yours and close mine :)

@SeunghoonBaek
Copy link
Author

SeunghoonBaek commented Jul 24, 2020

Hey @raedatoui , Thanks for checking my change.
Please feel free to tell me what about need to be changed more in my change. :)
Thanks a lot!

@raedatoui
Copy link

it looks fine, it just needs approval from @worldveil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants