run cleanup command after upload and ask to cleanup terms in poeditor

[yinx]

No description provided.

[gdebrauwer]

Suggested change

	$diff = collect(app(Poeditor::class)->download($this->getPoeditorLocale()))->dot()
	->diff(collect($translations)->dot());
	if ($diff->isEmpty()) {
	$this->info('The translations match the ones on POEditor');
	} else {
	$this->error('The following translations do not match the ones on POEditor:');
	$this->table(['Key', 'Value'], $diff->map(function ($value, $key) {
	return [$key, $value];
	}));
	if ($this->ask('Do you want to clean up the translations on POEditor? (y/n)')) {
	$response = app(Poeditor::class)->upload($this->getPoeditorLocale(), $translations, true, true);
	$this->info("Deleted {$response->getDeletedTermsCount()} terms");
	}
	}
	collect(app(Poeditor::class)->download($this->getPoeditorLocale()))
	->dot()
	->keys()
	->diff(collect($translations)->dot()->keys())
	->whenNotEmpty(function ($locallyDeletedTranslationsKeys) use ($translations) {
	$this->error('The following translation keys do not exist locally but do exist in POEditor:');
	$this->table(
	['Translation Key'],
	$locallyDeletedTranslationsKeys->map(fn ($key) => [$key])->all()
	);
	if (! $this->confirm('Do you want to delete those translation keys in POEditor? (y/n)')) {
	return;
	}
	$response = app(Poeditor::class)->upload($this->getPoeditorLocale(), $translations, true, true);
	$this->info("Deleted {$response->getDeletedTermsCount()} terms");
	});

[gdebrauwer]

@yinx Maybe we can make it even simpler.

Now we first upload, then download and compare the download with local, and finally we upload to delete terms

But what if we first download, then compare the download with local, and then upload with correct "sync" parameter 🤔 Then only one upload as necessary and only upload response needs to be shown

[gdebrauwer]

Suggested change

	public function it_asks_for_confirmation_when_translations_do_not_match_with_cleanup_enabled()
	public function it_asks_for_confirmation_when_local_translations_keys_do_not_match_translations_keys_in_poeditor()

[gdebrauwer]

is this not covered by all the other tests 🤔

[gdebrauwer]

Suggested change

	->expectsOutput('Deleted ' . 1 . ' terms')
	->expectsOutput("{$response->getDeletedTermsCount()} terms deleted")

[gdebrauwer]

Suggested change

	], true, true, new UploadResponse([
	'result' => [
	'terms' => ['added' => $this->faker->randomNumber(), 'deleted' => 1],
	'translations' => ['added' => $this->faker->randomNumber(), 'updated' => $this->faker->randomNumber()],
	],
	]));
	], true, true, $response = $this->getPoeditorUploadResponse());

[gdebrauwer]

Suggested change

	$cleanup = false;
	collect(app(Poeditor::class)->download($this->getPoeditorLocale()))
	->dot()
	->keys()
	->diff(collect($translations)->dot()->keys())
	->whenNotEmpty(function ($locallyDeletedTranslationsKeys) use (&$cleanup) {
	$this->error('The following translation keys do not exist locally but do exist in POEditor:');
	$this->table(
	['Translation Key'],
	$locallyDeletedTranslationsKeys->map(fn ($key) => [$key])->all()
	);
	if ($this->confirm('Do you want to delete those translation keys in POEditor? (y/n)')) {
	$cleanup = true;
	}
	});
	$cleanup = collect(app(Poeditor::class)->download($this->getPoeditorLocale()))
	->dot()
	->keys()
	->diff(collect($translations)->dot()->keys())
	->whenNotEmpty(function ($locallyDeletedTranslationsKeys) use (&$cleanup) {
	$this->error('The following translation keys do not exist locally but do exist in POEditor:');
	$this->table(
	['Translation Key'],
	$locallyDeletedTranslationsKeys->map(fn ($key) => [$key])->all()
	);
	return $this->confirm('Do you want to delete those translation keys in POEditor? (y/n)');
	}, fn () => false);

[gdebrauwer]

Suggested change

	$this->mockPoeditorUpload('en', [
	'php-file' => [
	'bar' => 'foo',
	],
	]);

can be removed as this upload is never executed