removed obsolete property in try catch + fix test name

wotzebra · Mar 30, 2023 · b580322 · b580322
1 parent a1a1779
commit b580322
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Http/Controllers/OpenApiJsonController.php b/src/Http/Controllers/OpenApiJsonController.php
@@ -19,7 +19,7 @@ public function __invoke(Request $request, string $filename) : JsonResponse
             $file = collect(config('swagger-ui.files'))->filter(function ($values) use ($filename, $path) {
                 return isset($values['versions'][$filename]) && ltrim($values['path'], '/') === $path;
             })->firstOrFail();
-        } catch (ItemNotFoundException $e) {
+        } catch (ItemNotFoundException) {
             return abort(404);
         }
 

diff --git a/src/Http/Controllers/SwaggerViewController.php b/src/Http/Controllers/SwaggerViewController.php
@@ -13,8 +13,8 @@ public function __invoke(Request $request)
             $file = collect(config('swagger-ui.files'))->filter(function ($values) use ($request) {
                 return ltrim($values['path'], '/') === $request->path();
             })->firstOrFail();
-        } catch (ItemNotFoundException $e) {
-            return response()->json(['error' => 'File not found'], 404);
+        } catch (ItemNotFoundException) {
+            return abort(404);
         }
 
         return view('swagger-ui::index', ['data' => collect($file)]);

diff --git a/tests/OpenApiRouteTest.php b/tests/OpenApiRouteTest.php
@@ -113,7 +113,7 @@ public function it_returns_not_found_response_if_provided_version_does_not_exist
     }
 
     /** @test */
-    public function it_returns_not_found_response_if_provided_file_does_not_exist()
+    public function it_returns_not_found_response_if_provided_file_does_not_exist_even_when_provided_version_exists()
     {
         $this->getJson('foo-bar/v1')
             ->assertStatus(404);