fix: support for floating numbers and large numbers on the slider #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add support for floating number * feat: add dynamic size on slider
FabienArcellier
force-pushed
the
561-support-for-floating-numbers-and-large-numbers-on-the-slider
branch
from
5d33935
to
a1960c0
Compare
madeindjs
approved these changes
Sep 17, 2024
Comment on lines
+67
to
+70
| const displayValue = computed(() => { | ||
| const precision = Math.ceil(-Math.log10(props.step)); | ||
| return model.value.toFixed(precision); | ||
| }); |
There was a problem hiding this comment.
I would use two computed values, because it avoids to re-compute precision when value change
Suggested change
| const displayValue = computed(() => { | |
| const precision = Math.ceil(-Math.log10(props.step)); | |
| return model.value.toFixed(precision); | |
| }); | |
| const precision = computed(() => Math.ceil(-Math.log10(props.step))); | |
| const displayValue = computed(() => model.value.toFixed(precision.value)); |
| @@ -190,6 +185,7 @@ function handleMouseDown(initialEvent: MouseEvent) { | |||
| top: 0; | |||
|
|
|||
| transition: box-shadow ease-in-out 0.5s; | |||
| transform: translateX(-50%); | |||
There was a problem hiding this comment.
Well seen, I didn't think about using this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #561, improve #505
The current component did not handle steps composed of decimals like 0.1 and 0.01. This PR adds support to permanently fix issue #225.
Decimal numbers can be quite large. The current implementation is of fixed size. The CSS code is modified so that the size of the popover is dynamic.