-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix capitalisation and punctuation in report #796
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,16 +45,18 @@ export class ReportQuery extends Component { | |
return this.props.query.hits.length; | ||
} | ||
headerJSX() { | ||
var meta = `length: ${this.queryLength().toLocaleString()}`; | ||
var length = `length: ${this.queryLength().toLocaleString()}`; | ||
var meta = length.charAt(0).toUpperCase() + length.slice(1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is
should be fixed, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's right, just make it simpler with I thought before, we need dynamic code, without live updates to |
||
|
||
if (this.props.showQueryCrumbs) { | ||
meta = `query ${this.props.query.number}, ` + meta; | ||
meta = `query ${this.props.query.number}. ` + meta; | ||
} | ||
return <div className="section-header border-b border-seqorange justify-between w-full flex flex-col sm:flex-row gap-4"> | ||
<h3 className="text-base cursor-pointer flex flex-col sm:flex-row items-start"> | ||
<strong>Query=<span className="ml-1">{this.props.query.id}</span></strong> | ||
<span className="ml-1">{this.props.query.title}</span> | ||
</h3> | ||
<span className="label text-sm text-right font-normal text-inherit pt-0 px-0">{meta}</span> | ||
<span className="label first-letter:capitalize text-sm text-right font-normal text-inherit pt-0 px-0">{meta}</span> | ||
</div>; | ||
} | ||
|
||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3lviend let's make string concatenation consistent,
'hit ${this.props.hit.number} of query ${this.props.query.number}. ' + meta;
to
'hit ${this.props.hit.number} of query ${this.props.query.number}. ${meta}';