Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdaptiveTree] On parsers use "und" language code for unknown cases #1731

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

"unk" uses is not really handled by kodi core so make conversion to fails by showing "unknown",
instead "und" lang code is expected by kodi core for "undetermined" language

On SmoothStreaming specs "und" language code is expected for unknown/neutral language on the Language tag
On DASH specs its not really defined, but shown on the manifest examples on AdaptationSet lang tag
On HLS its not considered as possible case for unknown, i think because the LANGUAGE tag is optional

Motivation and context

im doing changes/cleanups on kodi core

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers labels Nov 21, 2024
@CastagnaIT CastagnaIT merged commit 9bf03c5 into xbmc:Piers Nov 23, 2024
8 of 10 checks passed
@CastagnaIT CastagnaIT deleted the lang_code_und branch November 23, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant