Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate logging to std::format #1751

Open
wants to merge 1 commit into
base: Piers
Choose a base branch
from
Open

Conversation

neo1973
Copy link
Member

@neo1973 neo1973 commented Jan 2, 2025

Description

Simple conversion of logging to use std::format.

Motivation and context

Primarily to have proper support to print std::string_view (see #1750). And also in general the syntax is nicer and compile time format string checks can catch certain errors.

How has this been tested?

Compiled and tested on x86_64 Linux. YouTube live streams and regular videos work.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@neo1973 neo1973 added Type: Improvement non-breaking change which improves existing functionality v22 Piers labels Jan 2, 2025
@neo1973
Copy link
Member Author

neo1973 commented Jan 3, 2025

Old toolchains are a PITA... I'll try to pull in fmtlib until all platforms catch up and support std::format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant