Support custom vc build tools #5823
Open
+96
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Nov 14, 2024
| if file then | ||
| local variables = {} | ||
| for line in file:gmatch("[^\r\n]+") do | ||
| local key, value = line:match("set%s+(.-)=(.*)") |
There was a problem hiding this comment.
为啥不走运行捕获 envs，至少稳定可靠。
直接语法解析 set，不太稳吧。如果 set 是在 if 分支里呢，怎么判断取到的当前有效值
waruqi
reviewed
Nov 14, 2024
| local file = io.readfile(opt.bat) | ||
| if file then | ||
| local variables = {} | ||
| for line in file:gmatch("[^\r\n]+") do |
waruqi
reviewed
Nov 14, 2024
| VCToolsInstallDir = VCToolsInstallDirs[1] | ||
| end | ||
|
|
||
| local WindowsSDKDir = path.join(vs_build_tools, "Windows Kits/10") |
waruqi
reviewed
Nov 14, 2024
| @@ -43,6 +43,8 @@ platform("windows") | |||
| , " e.g. --vs_sdkver=10.0.15063.0" } | |||
| , {nil, "vs_runtime", "kv", nil, "The Runtime library of Visual Studio (deprecated, please use --runtimes)" | |||
| , values = {"MT", "MTd", "MD", "MDd"} } | |||
| , {nil, "vc_bat", "kv", nil, "The BuildTools bat file" | |||
| , " e.g. --vc_bat=C:/BuildTools/devcmd.bat" } | |||
waruqi
reviewed
Nov 14, 2024
| function load_custom_vcenv(opt) | ||
| opt = opt or {} | ||
|
|
||
| if opt.bat and os.isfile(opt.bat) then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5732