-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various defaults #146
Add various defaults #146
Conversation
663d012
to
9dde7b7
Compare
What do you think about a "Global" category? |
I think global for I'd personally get rid of the "custom" categories and make it all based on the I think everything's currently organized by domain except |
This reorganizes defaults file by domain and hoists the domain up into the category section. I was fixing some of the descriptions to make them proper markdown, and I discovered they actually aren't processed as markdown like I thought, which means the meta tags and the layout on category pages broke when I started using real markdown. I've updated the templates to fix this. I've also tightened up the json schema a bit, which can also be extracted from this PR. I'm going to need to apply the markdown fixes for yannbertrand#146, but the reorganization is a proposal for discussion.
This reorganizes defaults file by domain and hoists the domain up into the category section. I was fixing some of the descriptions to make them proper markdown, and I discovered they actually aren't processed as markdown like I thought, which means the meta tags and the layout on category pages broke when I started using real markdown. I've updated the templates to fix this. I've also tightened up the json schema a bit, which can also be extracted from this PR. I'm going to need to apply the markdown fixes for yannbertrand#146, but the reorganization is a proposal for discussion.
Here's an example of that organization - apexskier/macos-defaults@markdown-support...apexskier:domain-organization |
I prefer to keep the categories as is, which is easier to understand from a non-dev/end user perspective |
Currently, page url generation (slugification) is just toLowerCase. In yannbertrand#146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
Currently, page url generation (slugification) is just toLowerCase. In #146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
Currently, page url generation (slugification) is just toLowerCase. In #146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
Currently, page url generation (slugification) is just toLowerCase. In #146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
Is the PR still a Draft? Let me know if I can review it 🙂 |
0099add
to
70e4323
Compare
a7bc1a8
to
9feedb1
Compare
Currently, page url generation (slugification) is just toLowerCase. In yannbertrand#146 I add some defaults that contain keys with spaces, which currently breaks. This pulls in `slugify` to add support, and shell escapes keys in examples.
I just found this site/repo and it's exactly what I was looking for. I normally manually hunt for defaults or use https://www.defaults-write.com (which is not really organized in a useful manner), and this looks like exactly the setup I've wanted.
I have my own system for managing defaults across multiple computers and have a pretty extensive collection I'd like to start contributing to this repository. This PR kicks things off with a number of global apple configurations, many of which come from the system preferences.
Edit: I've now added quite a bit more, and will probably keep doing so until #150 and #151 are in.