fix(plugin-pnp): fix NODE_OPTIONS
parsing in setupScriptEnvironment
#6439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
setupScriptEnvironment
uses a simple regexp to detect whether the hook is injected insideNODE_OPTIONS
in order to remove it, but that check is flawed:--require
's shorthand:-r
--require=
/--experimental-loader=
)--report-dir "/path/to/--require .pnp.cjs"
)Closes #3232 (supersedes).
How did you fix it?
Implemented a basic regexp argument parser that can handle arguments composed of both plain and double quoted segments.
Double-quoted segments support escaping via backslash, just like Node's parser allows.
Single-quoted segments aren't allowed by Node.
Note that this isn't about the classic meaning of "parsing CLI arguments" (which
util.parseArgs
andclipanion
do), but about parsing a string into theargv
array for further processing.I added tests for everything.
Checklist