Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): fix E2E ESLint #6542

Closed
wants to merge 1 commit into from
Closed

Conversation

k1tikurisu
Copy link
Contributor

@k1tikurisu k1tikurisu commented Oct 5, 2024

What's the problem this PR addresses?

related: related #6545

The job named "E2E ESLint" has failed because it did not support ESLint v9.
...

How did you fix it?

I updated the E2E ESLint configuration to use the flat config format, which is the default in ESLint v9.

ask

The fixed E2E tests are failing for a different reason, but I don't know why.
It passes when run through Yarn v4.5.0 in the local environment.

Error: @typescript-eslint/utils tried to access eslint (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous and unsound.

Required package: eslint (via "eslint/use-at-your-own-risk")
Required by: @typescript-eslint/utils@virtual:45b3e83e1b[75](https://github.com/yarnpkg/berry/actions/runs/11192853600/job/31117504411#step:5:83)d7e41c682fbab9da6e963fc154f47b8379f0d9f403548c327a0d4494acd58f4cc8faed5652f06329e53049faa0f78df2e5b8d51646a46f94da01#npm:8.8.0 (via /tmp/tmp.aaqnDR1dSF/.yarn/__virtual__/@typescript-eslint-utils-virtual-a1dee45887/3/home/runner/.yarn/berry/cache/@typescript-eslint-utils-npm-8.8.0-be40d0f957-10c0.zip/node_modules/@typescript-eslint/utils/dist/ts-eslint/eslint/)

Ancestor breaking the chain: @typescript-eslint/type-utils@virtual:ade96ce131f5234a1125fbca8bf0580592094ab7fc850f329fd5c0638a369ebf1362f5acc310ce28926c68141cd8b708d84bcc5af4e6726b383f0b4149003cd3#npm:8.8.0
Ancestor breaking the chain: typescript-eslint@virtual:d77970ed84260d015cac656a2186bf8383aa098235a1924d86f512e888152c2dc341854e051d144cc54ee50c91560e7afa86e74[76](https://github.com/yarnpkg/berry/actions/runs/11192853600/job/31117504411#step:5:84)316e21f415a04e2f4a7f671#npm:8.8.0

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@k1tikurisu k1tikurisu marked this pull request as draft October 5, 2024 11:23
@k1tikurisu k1tikurisu changed the title Support ESLint v9 in E2E ESLint ci(e2e): Support ESLint v9 in E2E ESLint Oct 5, 2024
@k1tikurisu k1tikurisu marked this pull request as ready for review October 5, 2024 13:14
@k1tikurisu k1tikurisu changed the title ci(e2e): Support ESLint v9 in E2E ESLint ci(e2e): fix E2E ESLint Oct 5, 2024
@k1tikurisu
Copy link
Contributor Author

duplicate #6444

@k1tikurisu k1tikurisu closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant