Skip to content

Commit

Permalink
runtime: add test skips for ios
Browse files Browse the repository at this point in the history
For golang#59912.
For golang#59913.
Updates golang#49182.

Change-Id: I3fcdfaca3a4f7120404e7a36b4fb5f0e57dd8114
Reviewed-on: https://go-review.googlesource.com/c/go/+/491095
TryBot-Bypass: Bryan Mills <[email protected]>
Run-TryBot: Bryan Mills <[email protected]>
Auto-Submit: Bryan Mills <[email protected]>
Reviewed-by: Austin Clements <[email protected]>
  • Loading branch information
Bryan C. Mills authored and gopherbot committed May 3, 2023
1 parent 47e6fd0 commit 5e349ac
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/runtime/crash_cgo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ func TestCgoExternalThreadSignal(t *testing.T) {

got := runTestProg(t, "testprogcgo", "CgoExternalThreadSignal")
if want := "OK\n"; got != want {
if runtime.GOOS == "ios" && strings.Contains(got, "C signal did not crash as expected") {
testenv.SkipFlaky(t, 59913)
}
t.Fatalf("expected %q, but got:\n%s", want, got)
}
}
Expand Down Expand Up @@ -528,6 +531,9 @@ func TestCgoTracebackSigpanic(t *testing.T) {
// than injecting a sigpanic.
t.Skip("no sigpanic in C on windows")
}
if runtime.GOOS == "ios" {
testenv.SkipFlaky(t, 59912)
}
t.Parallel()
got := runTestProg(t, "testprogcgo", "TracebackSigpanic")
t.Log(got)
Expand Down Expand Up @@ -650,7 +656,7 @@ func TestSegv(t *testing.T) {

// No runtime errors like "runtime: unknown pc".
switch runtime.GOOS {
case "darwin", "illumos", "solaris":
case "darwin", "ios", "illumos", "solaris":
// Runtime sometimes throws when generating the traceback.
testenv.SkipFlaky(t, 49182)
case "linux":
Expand Down

0 comments on commit 5e349ac

Please sign in to comment.