This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
support for revved files with suffix/postfix naming #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(foo.7483.js instead of 7483.foo.js) switched from mocha to grunt-mocha-cli to enable testing on Windows. also results in less config and prettier colors. normalized file paths in test code to make tests pass on Windows. fixed a globbing bug that only occurs on Mac OS when the pattern starts with #. hooray for the existing test which caught this!
|
Impressive work, and btw first pull request in v2.0 ! Thanks ! |
sleeper
added a commit
that referenced
this pull request
May 22, 2013
support for revved files with suffix/postfix naming
|
Merged !!! Waiting for the change in grunt-rev, I'm going to add support for postfix as well (i.e. will detect either suffix or postfix) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the usemin piece to support grunt-rev's change to suffix/postfix naming described in sebdeckers/grunt-rev#2. The corresponding grunt-rev PR can be found at sebdeckers/grunt-rev#8.
The necessary changes were larger than I expected, partially due to a desire to get the tests to pass on Windows as well as Mac. If you'd like to reduce the changes, let me know and I'll take out the Windows-specific changes. If it's preferable to wait until v2.0 is merged into master, I can wait for that and then rebase this PR onto master.
I've signed the CLA.