Use URL-safe Base64 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be rather annoying to break everyone's sessions. We could let the code accept the old sessions while producing the new ones only. This would add complexity and be an annoyance if you deployed the old and new versions side-by-side, but would avoid making everyone re-login. My current opinion is that while I agree that using Base64URL makes sense, your use case isn't compelling enough for the added complexity. However, if we ever did some other breaking change (e.g., #31), we should do this one, too. |
|
Agreed, we have a workaround for this -- let's wait for now. Should I close this or leave as-is? |
|
Let's leave it open as a reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this library to implement OAuth2 authorization server (particularly, my access tokens, refresh tokens and codes are all just encrypted JSONs with IDs, wrapped into different records for results to not be interchangeable). Some of them are required to be sent and received over URLs, so the result needs to be URL-safe. As a workaround for now I just convert into URL-safe Base64 before sending to client (and re-convert back when receiving). This commit changes used Base64 encoding to be URL safe. This should break existing sessions for people and I don't know how bad can this impact be. However, I think this is a good use-case for this library and it should be URL-safe out of the box.