Fix: parse blocks after nested blocks. #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stopgap measure to enable this library to parse e.g. Bootstrap
4.3.1.
The problem can be illustrated by the example:
nestedParse
parses the first block inside a nested block on its own,(in this case:
foo {}
), then usesblocksParser
to read the rest. Theprevious version of
blocksParser
is too greedy and consumes everythinguntil the next '{'. In this case:
} bar
becomes a "selector", thebar
block becomes the next "subblock" of
@media
and the "absent" '}' for@media {
fails parsing.This patch uses '}' as a character that is highly unlikely to happen
inside a selector (although it's still possible, e.g.
[attr="}"]
) andhighly likely to terminate one-block @-blocks.
Previously, css-text failed on Bootstrap 4.3.1 at the 94th block, now it
can parse all of its >1200 blocks (not completely correctly, but rather
fine for CSS and such a tiny library!).