Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - Static method queryFormats should not be called dynamically #4546

Closed
wants to merge 0 commits into from
Closed

FIX - Static method queryFormats should not be called dynamically #4546

wants to merge 0 commits into from

Conversation

apphp
Copy link
Contributor

@apphp apphp commented Jan 30, 2024

Static method $imagick::queryFormats() should not be called dynamically

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jan 30, 2024

PR Summary

  • Modification in CCaptcha.php
    The way method queryFormats is used in the code has been updated. Previously, the method was being called directly on the 'imagick' object. Now, it is being called statically, meaning it's accessed directly from the class and not an instance of the class. This may enhance the efficiency of the code.

@apphp
Copy link
Contributor Author

apphp commented Jan 30, 2024

image

marcovtwout
marcovtwout requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@marcovtwout marcovtwout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Your PR contains some irrelevant historical commits. Could you rebase and only supply the relevant commit, and also update CHANGELOG.md?

framework/web/widgets/captcha/CCaptcha.php Outdated
@@ -169,7 +169,7 @@ public static function checkRequirements($extension=null)
if(extension_loaded('imagick'))
{
$imagick=new Imagick();
$imagickFormats=$imagick->queryFormats('PNG');
$imagickFormats=$imagick::queryFormats('PNG');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $imagick=new Imagick(); is no longer nessecary.

@apphp apphp closed this Feb 1, 2024
@apphp apphp mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcovtwout marcovtwout marcovtwout requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apphp @marcovtwout