Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: デフォルト値の設定 #196 #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuta0709
Copy link
Member

@yuta0709 yuta0709 commented Mar 9, 2022

Overview

  • ユーザー情報のデフォルト値を設定
  • ユーザー編集画面に飛ぶリンクはヘッダーのアイコンクリック時のメニューに実装済みだったので変更なし

Issue number

Close #196

How to check the revision

Points for Review

Remarks

@yuta0709 yuta0709 requested review from is-hoku and Dz0526 March 9, 2022 05:29
@yuta0709 yuta0709 self-assigned this Mar 9, 2022
Copy link
Collaborator

@Dz0526 Dz0526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました👍

@@ -28,18 +28,42 @@ const UserPage: NextPage = () => {
UserUpdateRequestFactory.createEmpty(),
);

const [username, setUsername] = useState<string>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これUserで状態持ったらもうちょいスッキリする気がする。どう?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ユーザ情報編集画面に飛ぶボタン&ユーザ情報編集にデフォルトValue設定
2 participants