Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix before_filter > before_action deprecation error (backward compatible) #67

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

knightq
Copy link

@knightq knightq commented Feb 14, 2018

No description provided.

@knightq
Copy link
Author

knightq commented Feb 19, 2018

Can anyone code-review and merge, please?

Copy link

@uzairfaisal uzairfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this gem no longer being maintained?

@@ -1,3 +1,8 @@
2.0.0
Copy link

@uzairfaisal uzairfaisal Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any major incompatible API changes ... maybe better to stick to 1.9.0?

@dlinch
Copy link

dlinch commented Jul 22, 2019

I would love for this to get merged. @zachinglis

Copy link

@uzairfaisal uzairfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code review only, this looks alright - just needs the correct version bump.

@@ -1,6 +1,6 @@
module Crummy
MAJOR = 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the breaking change (removing ruby 1.9 support) - in that case, this should be:

Suggested change
MAJOR = 1
MAJOR = 2
MINOR = 0
PATCH = 0

@descovi
Copy link

descovi commented Apr 21, 2023

I made a fork https://github.com/rubynetti/crummy with support for rails 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants