Fix alloc test

zalando · Mar 19, 2024 · c839ab5 · c839ab5
1 parent 6f6ab9c
commit c839ab5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/filters/tracing/statebagtotag_test.go b/filters/tracing/statebagtotag_test.go
@@ -6,6 +6,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/otel/trace/noop"
 
 	"github.com/zalando/skipper/filters"
 	"github.com/zalando/skipper/filters/filtertest"
@@ -66,9 +67,12 @@ func TestStateBagToTag(t *testing.T) {
 func TestStateBagToTagAllocs(t *testing.T) {
 	req := &http.Request{Header: http.Header{}}
 
-	span := &tracing.SpanWrapper{Ot: tracingtest.NewOtSpan("start_span")}
+	tr := noop.NewTracerProvider().Tracer("start_tracer")
+	sCtx, span := tr.Start(req.Context(), "start_span")
+	req = req.WithContext(sCtx)
+
 	req = req.WithContext(tracing.ContextWithSpan(req.Context(), span))
-	ctx := &filtertest.Context{FRequest: req, FStateBag: map[string]interface{}{"item": "val"}}
+	ctx := &filtertest.Context{FRequest: req, FStateBag: map[string]interface{}{"item": "val"}, FTracer: tr}
 
 	f, err := NewStateBagToTag().CreateFilter([]interface{}{"item", "tag"})
 	require.NoError(t, err)

diff --git a/tracing/tracingtest/testtracer.go b/tracing/tracingtest/testtracer.go
@@ -4,7 +4,6 @@ Package tracingtest provides an OpenTracing implementation for testing purposes.
 package tracingtest
 
 import (
-	"fmt"
 	"net/http"
 	"time"
 
@@ -165,7 +164,6 @@ func (s *OtSpan) SetOperationName(operationName string) tracing.Span {
 
 // Adds a tag to the span.
 func (s *OtSpan) SetTag(key string, value interface{}) tracing.Span {
-	fmt.Println("key: ", key, "; value: ", value)
 	s.Tags[key] = value
 	return s
 }