Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: ingore OPA updates #3334

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

MustafaSaber
Copy link
Member

@MustafaSaber MustafaSaber commented Dec 6, 2024

We decided to ignore automatically updating OPA dependencies. It was already done in #3332 (comment) & #3320 (comment)

This PR is to add visibility and we will run @dependabot unignore ... after merging.

See ignore docs

We decided to ignore automatically updating OPA dependencies. It was already done in #3332 (comment) & #3320 (comment)

This PR is to add visibility and we will run `@dependabot unignore ...` after merging.

See [`ignore` docs](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#ignore)

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@MustafaSaber MustafaSaber added the minor no risk changes, for example new filters label Dec 6, 2024
@MustafaSaber MustafaSaber self-assigned this Dec 6, 2024
@Pushpalanka
Copy link
Collaborator

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member

👍

@MustafaSaber MustafaSaber merged commit d8d1bbf into master Dec 6, 2024
14 checks passed
@MustafaSaber MustafaSaber deleted the add-dependabot-ignore-list branch December 6, 2024 14:42
@AlexanderYastrebov
Copy link
Member

AlexanderYastrebov commented Dec 19, 2024

Looking at #3346 I see it tries to update github.com/envoyproxy/go-control-plane - could you please check whether it is related or independent from OPA dependencies?

$ go mod why -m github.com/envoyproxy/go-control-plane
# github.com/envoyproxy/go-control-plane
github.com/zalando/skipper/filters/openpolicyagent
github.com/envoyproxy/go-control-plane/envoy/config/core/v3

MustafaSaber added a commit that referenced this pull request Dec 19, 2024
follow up on #3334

[ ] unignore `github.com/envoyproxy/go-control-plane`

Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber added a commit that referenced this pull request Dec 19, 2024
follow up on #3334

- [ ] unignore `github.com/envoyproxy/go-control-plane`

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@MustafaSaber
Copy link
Member Author

Looking at #3346 I see it tries to update github.com/envoyproxy/go-control-plane - could you please check whether it is related or independent from OPA dependencies?

#3351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants