Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List statuses in release details #2922

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

List statuses in release details #2922

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e367a20
List statuses in release details
dasch Sep 5, 2018
1e3c297
Ignore a Brakeman warning
dasch Sep 12, 2018
f80bd42
Share a partial
dasch Sep 12, 2018
86519db
Refactor to allow getting statuses for a changeset
dasch Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/changeset.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
class Changeset
attr_reader :repo, :previous_commit, :commit
BRANCH_TAGS = ["master", "develop"].freeze
ATTRIBUTE_TABS = %w[files commits pull_requests risks jira_issues].freeze
ATTRIBUTE_TABS = %w[files commits pull_requests statuses risks jira_issues].freeze

def initialize(repo, previous_commit, commit)
@repo = repo
Expand Down
3 changes: 3 additions & 0 deletions app/views/changeset/_statuses.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<% @release.github_status.statuses.each do |status| %>
<%= github_commit_status_icon(status.state) %> <b><%= status.context %>:</b> <%= link_to status.description, status.url %><br/>
<% end %>
5 changes: 5 additions & 0 deletions app/views/releases/row_content.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<li><a href="#pull_requests-<%= @release.version %>" data-toggle="tab">Pull Requests</a></li>
<li class="active"><a href="#commits-<%= @release.version %>" data-toggle="tab">Commits</a></li>
<li><a href="#files-<%= @release.version %>" data-toggle="tab">Files</a></li>
<li><a href="#statuses-<%= @release.version %>" data-toggle="tab">Statuses</a></li>
<li><a href="#risks-<%= @release.version %>" data-toggle="tab">Risks</a></li>
<li><a href="#jira_issues-<%= @release.version %>" data-toggle="tab">JIRA Issues</a></li>
</ul>
Expand All @@ -26,6 +27,10 @@
<%= render 'changeset/files', changeset: @changeset %>
</div>

<div class="tab-pane" id="statuses-<%= @release.version %>">
<%= render 'changeset/statuses', changeset: @changeset %>
</div>

<div class="tab-pane" id="risks-<%= @release.version %>">
<%= render 'changeset/risks', changeset: @changeset, type: "release" %>
</div>
Expand Down
24 changes: 21 additions & 3 deletions config/brakeman.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,25 @@
{
"ignored_warnings": [

{
"warning_type": "Cross-Site Scripting",
"warning_code": 4,
"fingerprint": "50350274f9c62a91f27562722e2191833e489c5eb093c411425b2472b6b7dbf2",
"check_name": "LinkToHref",
"message": "Potentially unsafe model attribute in link_to href",
"file": "app/views/changeset/_statuses.html.erb",
"line": 2,
"link": "https://brakemanscanner.org/docs/warning_types/link_to_href",
"code": "link_to((Unresolved Model).new.description, (Unresolved Model).new.url)",
"render_path": [{"type":"controller","class":"ReleasesController","method":"show","line":10,"file":"app/controllers/releases_controller.rb"},{"type":"template","name":"releases/row_content","line":31,"file":"app/views/releases/row_content.html.erb"}],
"location": {
"type": "template",
"template": "changeset/_statuses"
},
"user_input": "(Unresolved Model).new.url",
"confidence": "Weak",
"note": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not should be something like Linking to github status url

}
],
"updated": "2018-01-12 08:38:04 -0800",
"brakeman_version": "4.1.1"
"updated": "2018-09-12 16:04:57 +0200",
"brakeman_version": "4.3.1"
}