-
Notifications
You must be signed in to change notification settings - Fork 50
[bc\break] Remove deprecated and validators auto injections #83
base: develop
Are you sure you want to change the base?
Conversation
c1525cd
to
fb1e741
Compare
These tests scenarios are tested by testIsRequiredVsAllowEmptyVsContinueIfEmptyVsIsValid
fb1e741
to
a3c66bf
Compare
Code coverage drop its for a difference between phpunit code coverage versions. |
* Remove AllowEmpty / ContinueIfEmpty deprecated on 2.4.8. Zend\Validator\NotEmpty should be added to the ValidatorChain when expected. * Remove UploadFile validator auto injection Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.
a3c66bf
to
7d8dd86
Compare
@Maks3w can you drop into the summary how users can emulate the behavior using validators? Most will likely see this issue, see that the functionality was removed, but not know how to accomplish the behavior on their own. Which brings me to the next point: can you start a migration/changes document detailing the change in behavior, please? |
@Maks3w Are you still working on this? |
I'm not sure if continue with this or rewrite the component. There is not urgency for to merge this |
This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at laminas/laminas-inputfilter#7. |
This repository has been moved to laminas/laminas-inputfilter. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Zend\Validator\NotEmpty should be added to the ValidatorChain when expected.
Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.
ToDo: