Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

[bc\break] Remove deprecated and validators auto injections #83

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Maks3w
Copy link
Member

@Maks3w Maks3w commented Dec 16, 2015

  • Remove AllowEmpty / ContinueIfEmpty deprecated on 2.4.8.
    Zend\Validator\NotEmpty should be added to the ValidatorChain when expected.
  • Remove UploadFile validator auto injection
    Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.

ToDo:

  • review coverage drop when uncovered lines grow

These tests scenarios are tested by testIsRequiredVsAllowEmptyVsContinueIfEmptyVsIsValid
@Maks3w Maks3w force-pushed the remove-deprecated-stuff branch from fb1e741 to a3c66bf Compare December 18, 2015 19:49
@Maks3w Maks3w added this to the 3.0.0 milestone Dec 18, 2015
@Maks3w
Copy link
Member Author

Maks3w commented Dec 18, 2015

Code coverage drop its for a difference between phpunit code coverage versions.

* Remove AllowEmpty / ContinueIfEmpty deprecated on 2.4.8.
  Zend\Validator\NotEmpty should be added to the ValidatorChain when expected.

* Remove UploadFile validator auto injection
  Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.
@Maks3w Maks3w force-pushed the remove-deprecated-stuff branch from a3c66bf to 7d8dd86 Compare December 19, 2015 09:24
@weierophinney
Copy link
Member

@Maks3w can you drop into the summary how users can emulate the behavior using validators? Most will likely see this issue, see that the functionality was removed, but not know how to accomplish the behavior on their own.

Which brings me to the next point: can you start a migration/changes document detailing the change in behavior, please?

@DASPRiD
Copy link
Member

DASPRiD commented May 8, 2016

@Maks3w Are you still working on this?

@Maks3w
Copy link
Member Author

Maks3w commented May 8, 2016

I'm not sure if continue with this or rewrite the component. There is not urgency for to merge this

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at laminas/laminas-inputfilter#7.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-inputfilter. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-inputfilter to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-inputfilter.
  • In your clone of laminas/laminas-inputfilter, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants