Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New duck #330

Closed
wants to merge 8 commits into from
Closed

Added New duck #330

wants to merge 8 commits into from

Conversation

kunal-511
Copy link

Description

Here my contribution to "The Duck Gallery".

Here is my contribution to "The Duck Gallery".
I have added a new duck image.

You must respect the following conditions

  1. Your contribution must respect the code of conduct
  2. It's your first PR to this repository
  3. You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
  4. You have not changed the image of the duck
  5. The image filename must be your GitHub username (ex: your-username.png)
  6. You are using your own GitHub user and it's the same as the PR author
  7. Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

@jeanphi-baconnais
Copy link
Member

Hi @kunal-511 , thanks for your contribution. For this type of contribution, you just have to add a duck and list on the contributor js file. Please reset your changes on package-lock and yarn lock file 🙏

@kunal-511
Copy link
Author

I have updated the code please merge it

@jeanphi-baconnais
Copy link
Member

I have updated the code please merge it

I always see changes on lock file 😕

@kunal-511
Copy link
Author

resolved please merge

Copy link
Member

@jeanphi-baconnais jeanphi-baconnais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes on lock file before

@jeanphi-baconnais jeanphi-baconnais dismissed their stale review October 6, 2023 08:05

Lock file are always present

@kunal-511
Copy link
Author

now check added the required file

@kunal-511 kunal-511 closed this by deleting the head repository Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants