Command Cmake added for mac os x install #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: CMakeLists.txt
In the process, improved const correctness and removed an unnecessary function parameter.
When hitting R, if the rectangle wasn't drawn from the top left corner to the bottom right corner, the program would crash, since it didn't do the extra processing it does when run with -s. Fixed that issue.
It was added as part of 4978fa7 and it is completely unnecessary.
Removed the using declarations from the header files and put them in the source files instead. This should make OpenTLD play nicer with other libraries.
These make it OK to call tld::TLD::release() repeatedly.
* `cmake` create the makefile needs to be executed in order to create a makefile for mac os x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake needs to be executed in the project dir in order to create a makefile