Inherit source code to causes as well as related errors #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment outer source code is supplied to inner related errors but not to causes. This PR changes that.
This allows late-supplied source code to be supplied using concrete types. Comparisons below…
Concrete types
Firstly, if we wrap our inner error with some well-typed outer wrapper:
At the moment we don’t get any source information rendered.
Output:
Wrapped in Report
On the other hand, if we wrap using
miette::Report
, which loses the underlying type information, we get the source code:Output:
Using related
Currently we can achieve something using
#[related]
but that is semantically-inappropriate for some use cases:The rendering is also different since they're rendered as adjacent errors rather than causes:
With proposed change
After this PR, the output for the first example (exact same code) should be similar to the last example, except exhibiting cause-nesting: