feat: add from_err()
method to Report
#403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no nice way to construct a bare
Report
from a regularError
type. You can constructResult<_, Report>
fromResult::<_, E: ...>
, but not from an error by itself.My workaround where
e: impl Error + Send + Sync + 'static
is to doErr::<(), _>(e).into_diagnostic().unwrap_err()
, which obviously is ugly.I added a
Report::from_err()
method that solves this problem in the same way as theIntoDiagnostic
trait, by using itsDiagnosticError
type.