feat(core): Optionally disable automatic endpoint fallback #2572
+90
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a link to https://zmk.dev/docs/keymaps/behaviors/outputs pointing to this? Perhaps an additional paragraph at the end of the summary section. |
joelspadin
reviewed
Oct 19, 2024
ReFil
force-pushed
the
disable-endpoint-fallback
branch
from
19fe994
to
5d23a98
Compare
joelspadin
requested changes
Oct 20, 2024
ReFil
force-pushed
the
disable-endpoint-fallback
branch
from
5d23a98
to
22a99e5
Compare
joelspadin
requested changes
Oct 25, 2024
|
@joelspadin sorry to be a pain, not sure if GitHub is playing up or something but I can't seem to see what changes you requested? |
joelspadin
reviewed
Oct 27, 2024
No idea where that comment went. I've added it again. |
caksoylar
added
core
ReFil
force-pushed
the
disable-endpoint-fallback
branch
from
22a99e5
to
121ff8b
Compare
joelspadin
reviewed
Nov 14, 2024
There was a problem hiding this comment.
This looks good to me now, but @petejohanson should probably take a look too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default if only one endpoint is connected but the other is selected, the connected endpoint will be chosen as a fallback, for boards with physical endpoint selection slide switches this can lead to confusing behaviour where one is selected but the other is used.
This adds a kConfig option
CONFIG_ZMK_ENDPOINT_DISABLE_FALLBACKthat, when enabled, switches the board to a different endpoint selection system that will only return the preferred transport or anew transportZMK_TRANSPORT_NONEthat just swallows any HID data.Tested with various combinations of USB and BLE and it seems to work as intended