Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unrecognized latency option #35

Merged
merged 2 commits into from
Oct 9, 2016
Merged

Removed unrecognized latency option #35

merged 2 commits into from
Oct 9, 2016

Conversation

bkuhl
Copy link
Collaborator

@bkuhl bkuhl commented Sep 20, 2016

#34

Copy link
Contributor

@psykzz psykzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be a better way to handle this based on the version?

If someone want to build this themselves this would break for older builds that support the option.

@bkuhl
Copy link
Collaborator Author

bkuhl commented Sep 20, 2016

They would need to clone this repo, checkout the tag associated with that version and build from there.

@psykzz
Copy link
Contributor

psykzz commented Sep 20, 2016

Not really just clone update the version ENV tag and build.

@bkuhl
Copy link
Collaborator Author

bkuhl commented Sep 20, 2016

Checking out the git tag will already have the Dockerfile they need that matches that version.

@psykzz
Copy link
Contributor

psykzz commented Sep 20, 2016

But im think if we include future features, like there are some commandline features we don't support currently, we might implement them and not backport.

Otherwise yeah i agree.

@bkuhl
Copy link
Collaborator Author

bkuhl commented Sep 20, 2016

Correct, they wouldn't be back ported. That's the reason to keep upgrading :) You can't ensure backwards compatibility, all the time.

Copy link
Contributor

@psykzz psykzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkuhl bkuhl merged commit fa63e2f into master Oct 9, 2016
@bkuhl bkuhl deleted the bkuhl-patch-1 branch October 9, 2016 21:47
@hub23
Copy link
Contributor

hub23 commented Oct 23, 2016

This still persists in the zopanix/factorio:v0.14.8-experimental build on docker hub, I can't launch the container, it exits with the following error: unrecognised option '--latency-ms'. The latest build is at 0.14.8 too and runs fine, maybe just rebuild the v0.14.8-experimental image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants