-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unrecognized latency option #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could there be a better way to handle this based on the version?
If someone want to build this themselves this would break for older builds that support the option.
They would need to clone this repo, checkout the tag associated with that version and build from there. |
Not really just clone update the version ENV tag and build. |
Checking out the git tag will already have the Dockerfile they need that matches that version. |
But im think if we include future features, like there are some commandline features we don't support currently, we might implement them and not backport. Otherwise yeah i agree. |
Correct, they wouldn't be back ported. That's the reason to keep upgrading :) You can't ensure backwards compatibility, all the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This still persists in the |
#34