Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LoginFilter failing in AccessToken generate filter chain #3984

Open
wants to merge 3 commits into
base: v2.x.x
Choose a base branch
from

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Feb 12, 2025

Description

in the access token (PAT) generation filter chain, StoreAccessTokenInfoFilter runs before LoginFilter, reading the input stream and making it unavailable for LoginFilter.

The change is to ignore body credentials if the attribute was set in StoreAccessTokenInfoFilter.

This issue was only observed with chunked HTTP request, with which the input stream replies with a positive integer in available() method. However, with non-chunked, available() is 0 after being read and the issue does not appear.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

@pablocarle pablocarle requested a review from arxioly February 12, 2025 15:50
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Feb 12, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review size/L
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant