fix: LoginFilter failing in AccessToken generate filter chain #3984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in the access token (PAT) generation filter chain, StoreAccessTokenInfoFilter runs before LoginFilter, reading the input stream and making it unavailable for LoginFilter.
The change is to ignore body credentials if the attribute was set in StoreAccessTokenInfoFilter.
This issue was only observed with chunked HTTP request, with which the input stream replies with a positive integer in
available()
method. However, with non-chunked,available()
is 0 after being read and the issue does not appear.Type of change
Checklist: