GH-226 Enhancement: Check connection for config file in parallel #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsytsen
force-pushed
the
feature/IJMP-2125
branch
2 times, most recently
from
a3dbf26 to
52055c8
Compare
KUGDev
changed the title
KUGDev
changed the title
KUGDev
changed the title
KUGDev
changed the title
KUGDev
changed the title
KUGDev
changed the title
KUGDev
changed the title
ktsytsen
force-pushed
the
feature/IJMP-2125
branch
2 times, most recently
from
71b8c5a to
abc6037
Compare
KUGDev
requested changes
Feb 3, 2025
src/main/kotlin/org/zowe/explorer/zowe/service/ZoweConfigServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/zowe/explorer/zowe/service/ZoweConfigServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/zowe/explorer/zowe/service/ZoweConfigServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/zowe/explorer/zowe/service/ZoweConfigServiceImpl.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/zowe/explorer/zowe/service/ZoweConfigServiceTestSpec.kt
Outdated
Show resolved
Hide resolved
ktsytsen
force-pushed
the
feature/IJMP-2125
branch
from
abc6037 to
cf1d91a
Compare
KUGDev
approved these changes
Feb 7, 2025
src/main/kotlin/org/zowe/explorer/zowe/service/ZoweConfigServiceImpl.kt
Outdated
Show resolved
Hide resolved
ktsytsen
force-pushed
the
feature/IJMP-2125
branch
from
cf1d91a to
55a4237
Compare
|
@Ivsh312 Could you please test this PR? |
|
@Ivsh312 says: Testing result: testing 3 connections:
If 2 and 1 connection incorrect Adjusted requirement: if some profiles have the same host and port - test only one of them |
ktsytsen
force-pushed
the
feature/IJMP-2125
branch
from
55a4237 to
ea12bba
Compare
KUGDev
approved these changes
Feb 17, 2025
Signed-off-by: Katsiaryna Tsytsenia <[email protected]>
ktsytsen
force-pushed
the
feature/IJMP-2125
branch
from
ea12bba to
523b3ad
Compare
|
@Ivsh312 Could you please retest? |
|
Problem found: In every case if we click "add connection" in config file, new connection is created and all connections are bound to the same node in config file. (insted update zowe do add) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.