Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open a Renamed Sequential DS #3439

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Unable to open a Renamed Sequential DS #3439

merged 4 commits into from
Feb 8, 2025

Conversation

SanthoshiBoyina1
Copy link
Contributor

@SanthoshiBoyina1 SanthoshiBoyina1 commented Feb 6, 2025

Proposed changes

Fixes #3345

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • [ x] All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Copy link

github-actions bot commented Feb 6, 2025

📅 Suggested merge-by date: 2/20/2025

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (eeeaf84) to head (3e27481).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3439   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         120      120           
  Lines       12660    12662    +2     
  Branches     2801     2875   +74     
=======================================
+ Hits        11804    11806    +2     
  Misses        855      855           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SanthoshiBoyina1 SanthoshiBoyina1 changed the title Rename Sequential DS not working correctly Unable to open a Renamed Sequential DS Feb 6, 2025
Signed-off-by: Santhoshi Boyina <[email protected]>
anaxceron
anaxceron previously approved these changes Feb 6, 2025
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor edits to the changelog entry

@@ -15,6 +15,7 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen

- Fixed an issue where a TypeError occurred when applying VS Code proxy settings to an invalid session. [#3425](https://github.com/zowe/zowe-explorer-vscode/issues/3425)
- Fixed issue where the 'Delete' key binding for the USS tree returns a 'contextValue' error. [#2796](https://github.com/zowe/zowe-explorer-vscode/issues/2796)
- Fixed the issue where user is unable to open a renamed sequential dataset from the DS tree. [#3345](https://github.com/zowe/zowe-explorer-vscode/issues/3345)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits, please: "Fixed an issue ... sequential data set from the Data Sets tree view."

Signed-off-by: Santhoshi Boyina <[email protected]>
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @SanthoshiBoyina1 for the fix!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

I know this wasn't part of the 3.1.1 milestone, but I'd not be opposed if this is cherry-picked into the prepare-3.1.1 branch 😅

@zFernand0 zFernand0 merged commit 51d6ab4 into main Feb 8, 2025
25 checks passed
@zFernand0 zFernand0 deleted the fix/renameSeqDS branch February 8, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Rename Sequential DS not working correctly
4 participants