-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to open a Renamed Sequential DS #3439
Conversation
Signed-off-by: Santhoshi Boyina <[email protected]>
📅 Suggested merge-by date: 2/20/2025 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 120 120
Lines 12660 12662 +2
Branches 2801 2875 +74
=======================================
+ Hits 11804 11806 +2
Misses 855 855
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Santhoshi Boyina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor edits to the changelog entry
packages/zowe-explorer/CHANGELOG.md
Outdated
@@ -15,6 +15,7 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen | |||
|
|||
- Fixed an issue where a TypeError occurred when applying VS Code proxy settings to an invalid session. [#3425](https://github.com/zowe/zowe-explorer-vscode/issues/3425) | |||
- Fixed issue where the 'Delete' key binding for the USS tree returns a 'contextValue' error. [#2796](https://github.com/zowe/zowe-explorer-vscode/issues/2796) | |||
- Fixed the issue where user is unable to open a renamed sequential dataset from the DS tree. [#3345](https://github.com/zowe/zowe-explorer-vscode/issues/3345) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor edits, please: "Fixed an issue ... sequential data set from the Data Sets tree view."
Signed-off-by: Santhoshi Boyina <[email protected]>
Signed-off-by: Santhoshi Boyina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @SanthoshiBoyina1 for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
I know this wasn't part of the 3.1.1 milestone, but I'd not be opposed if this is cherry-picked into the prepare-3.1.1 branch 😅
Proposed changes
Fixes #3345
Release Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments