Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update-sdks to fix cross-lpar copy alc unit #3467

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: update-sdks to fix cross-lpar copy alc unit #3467

merged 2 commits into from
Feb 18, 2025

Conversation

zFernand0
Copy link
Member

Proposed changes

Fix #3402 by updating upstream dependencies

Release Notes

Milestone: 3.2.0

Changelog: No changelog required as this is only an issue in main

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

This is an issue found only in main, and thus it doesn't need ported to 3.1.2

@zFernand0 zFernand0 added the no-changelog Add to PR's that don't require a CHANGELOG update label Feb 18, 2025
@zFernand0 zFernand0 added this to the v3.2.0 milestone Feb 18, 2025
@zFernand0 zFernand0 self-assigned this Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (ed05975) to head (31d45a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3467    +/-   ##
========================================
  Coverage   93.25%   93.25%            
========================================
  Files         120      120            
  Lines       12692    12692            
  Branches     2882     2762   -120     
========================================
  Hits        11836    11836            
  Misses        855      855            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

📅 Suggested merge-by date: 3/4/2025

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the SDKs @zFernand0 works well but did see an error with copy/paste of a PDS that's empty but did do the paste
Screenshot 2025-02-18 at 9 47 19 AM

@traeok
Copy link
Member

traeok commented Feb 18, 2025

thanks for updating the SDKs @zFernand0 works well but did see an error with copy/paste of a PDS that's empty but did do the paste

@JillieBeanSim This seems related to recent work on PDS copy/paste functionality - should we file this as a separate issue? I haven't spotted any changes in this PR that could cause this error

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fernando for the dep updates!

@zFernand0
Copy link
Member Author

Thank you both for the quick reviews 🙏
I'm happy to go either way (separate issue, or spend a bit more time understanding the copy/paste PDS behavior to fix it here) 🙏

@JillieBeanSim
Copy link
Contributor

separate issue/PR for the copy/paste bug is fine with me, thanks all 😄

@JillieBeanSim JillieBeanSim self-requested a review February 18, 2025 15:44
@zFernand0 zFernand0 merged commit 53d3fd7 into main Feb 18, 2025
24 checks passed
@zFernand0 zFernand0 deleted the f/fix-3402 branch February 18, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update size/S
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

ds: Dataset creation always uses TRACKS when copying them
3 participants