-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zulip: Standardize the names of bindings with OperationIDs. #712
base: main
Are you sure you want to change the base?
Conversation
632432e
to
1974ad4
Compare
I have manually audited, and these are all the bindings whose names don't match the operationIDs as defined in |
Thanks for doing this audit @MSurfer20! I started https://chat.zulip.org/#narrow/stream/378-api-design/topic/python.20bindings.20function.20names/near/1255079 for discussion. |
50bbad8
to
67ce679
Compare
Some bindings had names that differed from the names that were used in the OperationID. This commit deprecates the older names, and changes the names of the bindings to match operationIDs.
This looks great; rebasing to get CI to run in case the new automated tests of the server implementation fail with the new deprecation warning logging output. I think we need to do one thing before merging:
Once that happens, we can merge this and our TODO to finish this cleanup process will be:
@MSurfer20 can you let @eeshangarg know when you expect to get to the |
Heads up @MSurfer20, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
No description provided.