Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Setup zulip server and install android sdk to run tests on travis. #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sam1301
Copy link
Member

@Sam1301 Sam1301 commented Jan 12, 2017

This pr addresses #271
Since dist trusty is not compatible with android on travis we need to install android sdk and other support libraries manually in order to make use of trusty to run zulip dev environment.

The existing tests are flaked (verified by me and kunal) so they have been commented out for now.

Since dist trusty is not compatible with language android on travis we
need to install android sdk and other support libraries on travis manually
in order to make use of trusty to run zulip dev environment.

The existing tests are flaked so they have been commented out for now.
@smarx
Copy link

smarx commented Jan 12, 2017

Automated message from Dropbox CLA bot

@Sam1301, it looks like you've already signed the Dropbox CLA. Thanks!

@timabbott
Copy link
Sponsor Member

@saketkumar95 @kunall17 @vishwesh3 can you give this a review?

@yadav-rahul
Copy link
Collaborator

@timabbott I can do it too if you agree.

@saketkumar
Copy link
Collaborator

@yadav-rahul Yeah sure do it. 👍

@yadav-rahul
Copy link
Collaborator

@saketkumar95 Thanks for your concern. Waiting for @timabbott reiview. :)

@timabbott
Copy link
Sponsor Member

@yadav-rahul you don't need my permission to do a code review; just review it and post your feedback :)

@yadav-rahul
Copy link
Collaborator

@timabbott OK :)

@kunall17
Copy link
Collaborator

kunall17 commented Feb 1, 2017

@timabbott This won't work now because the espresso test's are flaky and they work sometimes and sometimes don't! https://github.com/zulip/zulip-android/issues/342

So we need to have some test's for the travis to run!

@timabbott
Copy link
Sponsor Member

Well we can do the infrastructure setup for Travis CI to be able to run a single do-nothing test with the app built, and get that debugged, while in parallel folks work on #342. So I think this is still useful to work on.

@zulipbot
Copy link
Member

zulipbot commented May 4, 2017

@Sam1301, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants