Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Fix minor bug in AutoCompleteTextView #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yadav-rahul
Copy link
Collaborator

This PR fixes limits maxLines in Stream's AutoCompleteTextView to 1.

  • Without this property, AutoCompleteTextView can display multiple lines at a time and thus giving poor User experience.

Before
rsz_stream

Now, it will work fine because maxLines are limited to one.

@smarx
Copy link

smarx commented Jan 30, 2017

Automated message from Dropbox CLA bot

@yadav-rahul, it looks like you've already signed the Dropbox CLA. Thanks!

@Sam1301
Copy link
Member

Sam1301 commented Jan 31, 2017

hmm.. I think on small screen devices this can be a problem. @kunall17 what are your thoughts on this?

@yadav-rahul
Copy link
Collaborator Author

Actually Topic's AutoCompleteTextView already has this property(android:maxLines="1"). Implementing same in Stream's AutoCompleteTextView would look better :)

@kunall17 What are your views on it?

@yadav-rahul
Copy link
Collaborator Author

yadav-rahul commented Jan 31, 2017

@timabbott @kunall17 Please review this PR :)

@kunall17
Copy link
Collaborator

Mostly the stream wouldn't be of more that 15 chars which means 2-3 lines (At the max) and by providing maxlines it would hide the text and giving 1 line more doesn't look that bad!

@timabbott
Copy link
Member

I could imagine rebalancing a bit how much space each of stream and topic get in that line (or giving each their own line)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants