Adding basic rpm build #1234
Open
Adding basic rpm build #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Off chance someone could take a look at this PR? It's been open for over a year and is very small. I don't know the organizational structure of Zulip, so I don't know who to ping. |
timabbott
reviewed
Nov 6, 2023
| update-desktop-database /usr/share/applications || true | ||
|
|
||
| # Clean up configuration for old Bintray repository | ||
| rm -f /etc/apt/zulip.list |
There was a problem hiding this comment.
This file will never exist in an RPM system.
|
It will be considered when we're next doing an Electron release. Though given the above bug, this seems to be somewhat sloppily implemented, so no promised that it'll prove easy to integrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a rpm build target to electron-builder
Any background context you want to provide?
Fixes #1139
You have tested this PR on: