Fix macOS icon. #1386
Open
Fix macOS icon. #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Could you please update your commit message to match the commit style guidelines? |
macOS icons were skewed for sizes 16x16, 32x32, 48x48 (see issue zulip#1316 ), affecting their display in Spotlight and Finder. A fixed `icon.icns` was built based on the icons in `build/icons` using the macOS-internal command `iconutil -c icns`.
|
Sure, does it comply now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS icons are skewed for sizes 16x16, 32x32, 48x48 (see issue #1316 ).
What's this PR do?
As previously mentioned in Issue #1316, the app icon in macOS looks skewed in Spotlight, Finder. This PR fixes this look.
Any background context you want to provide?
I created a new
icon.icnsbased on the icons inbuild/iconsusingiconutil -c icns.Screenshots
Before:
After:
You have tested this PR on: