wip

Signed-off-by: Zixuan James Li <[email protected]>
zulip · Aug 20, 2024 · 2315cd2 · 2315cd2
1 parent 05a7975
commit 2315cd2
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 21 deletions.
diff --git a/lib/model/typing_status.dart b/lib/model/typing_status.dart
@@ -91,7 +91,7 @@ class TypingStatus extends ChangeNotifier {
 
 /// Manages updates to the user's typing status.
 ///
-/// See the server implementation:
+/// See the web implementation:
 ///   https://github.com/zulip/zulip/blob/52a9846cdf4abfbe937a94559690d508e95f4065/web/shared/src/typing_status.ts
 class TypingNotifier {
   TypingNotifier({

diff --git a/test/widgets/compose_box_test.dart b/test/widgets/compose_box_test.dart
@@ -55,6 +55,8 @@ void main() {
     return controllerKey;
   }
 
+  // TODO prepareComposeBoxWithNavigation
+
   group('ComposeContentController', () {
     group('insertPadded', () {
       // Like `parseMarkedText` in test/model/autocomplete_test.dart,
@@ -198,16 +200,16 @@ void main() {
 
       testWidgets('$narrow: unfocusing content input stops previous typing notification', (tester) async {
         // TODO
-        // await prepareComposeBox(tester, narrow: narrow);
+        await prepareComposeBox(tester, narrow: narrow);
 
-        // connection.prepare(json: {});
-        // await tester.enterText(contentInputFinder, 'hello world');
-        // checkTypingRequest(TypingOp.start, narrow);
+        connection.prepare(json: {});
+        await tester.enterText(contentInputFinder, 'hello world');
+        checkTypingRequest(TypingOp.start, narrow);
 
-        // connection.prepare(json: {});
-        // await tester.press(find.widgetWithIcon(IconButton, Icons.attach_file));
-        // await tester.pump();
-        // checkTypingRequest(TypingOp.stop, narrow);
+        connection.prepare(json: {});
+        await tester.tap(find.widgetWithIcon(IconButton, Icons.attach_file));
+        await tester.pump();
+        checkTypingRequest(TypingOp.stop, narrow);
       });
     }
 
@@ -233,18 +235,24 @@ void main() {
 
     testWidgets('unfocusing content input stops previous typing notification', (tester) async {
       // TODO
-      // const narrow = ChannelNarrow(123);
-      // await prepareComposeBox(tester, narrow: narrow);
-
-      // await tester.enterText(topicInputFinder, 'topic');
-      // // Clean an irrelevant topic request.
-      // check(connection.takePreviousRequests()).single
-      //   ..method.equals('GET')
-      //   ..url.path.equals('/api/v1/users/me/123/topics');
-
-      // connection.prepare(json: {});
-      // await tester.enterText(contentInputFinder, 'hello world');
-      // checkTypingRequest(TypingOp.start, TopicNarrow(narrow.streamId, 'topic'));
+      const narrow = ChannelNarrow(123);
+      await prepareComposeBox(tester, narrow: narrow);
+
+      await tester.enterText(topicInputFinder, 'topic');
+      // Clean an irrelevant topic request.
+      check(connection.takePreviousRequests()).single
+        ..method.equals('GET')
+        ..url.path.equals('/api/v1/users/me/123/topics');
+
+      connection.prepare(json: {});
+      await tester.enterText(contentInputFinder, 'hello world');
+      checkTypingRequest(TypingOp.start, TopicNarrow(narrow.streamId, 'topic'));
+
+      connection.prepare(json: {});
+      // await tester.enterText(topicInputFinder, 'asd');
+      await tester.tap(topicInputFinder);
+      await tester.pump();
+      checkTypingRequest(TypingOp.stop, TopicNarrow(narrow.streamId, 'topic'));
     });
   });