Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for supporting set typing status #888

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Prep for supporting set typing status #888

merged 6 commits into from
Sep 16, 2024

Commits on Sep 16, 2024

  1. api [nfc]: Fix outdated update instructions. 

    UserSettingName has been moved to another file.

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208 @gnprice
    PIG208 authored and gnprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b45a7c0 View commit details
    Browse the repository at this point in the history

  2. api [nfc]: Support const constructor for MessageDestination. 

    Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208 @gnprice
    PIG208 authored and gnprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d764cea View commit details
    Browse the repository at this point in the history

  3. typing_status [nfc]: Remove debugLog for adding self as typist. 

    This is not prohibited by the server and we should not log expected
behaviors like this.

See:

  https://zulip.com/api/get-events#typing-start

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208 @gnprice
    PIG208 authored and gnprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    850e59f View commit details
    Browse the repository at this point in the history

  4. fake_api: Allow recording and taking multiple requests. 

    Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208 @gnprice
    PIG208 authored and gnprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d458496 View commit details
    Browse the repository at this point in the history

  5. fake_api: Support preparing a queue of responses. 

    An issue that exists prior to this change is that there can be unused
prepared responses when the test ends, but we don't have a way to
detect that. We can potentially do something like what testWidgets
does with pending timers.

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208 @gnprice
    PIG208 authored and gnprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7fe8048 View commit details
    Browse the repository at this point in the history

  6. api: Add route setTypingStatus. 

    The three legacy cases will need to be dropped separately at different
server versions. The tests will fail accordingly as we do that.

Signed-off-by: Zixuan James Li <[email protected]>
    @PIG208 @gnprice
    PIG208 authored and gnprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e974ed3 View commit details
    Browse the repository at this point in the history